Repository navigation
Conversation
beekld
marked this pull request as ready for review
November 6, 2026 03:27
beekld
force-pushed
the
bklimt/SDK-3402/monotonic-deadlines
branch
from
November 6, 2026 03:36
b97b53a to
7a1fa34
Compare
beekld
force-pushed
the
bklimt/SDK-3402/monotonic-deadlines
branch
from
November 6, 2026 17:37
7a1fa34 to
5198a56
Compare
tanderson-ld
approved these changes
Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The FDv2 synchronizer loop measured its deadlines against the wall clock. When the system clock stepped backwards, every pending deadline was delayed by the size of the step. If every synchronizer was parked for 5 minutes and the clock stepped back an hour, no synchronizer ran for 65 minutes.
These deadlines now use
MonotonicTime, a small value class overSystem.nanoTime(), so changes to the system clock don't move them.Stacked on #252.
Note
Overview
What changes
FDv2 synchronizer deadlines (recovery, fallback, wake scheduling), FDv1 fallback end times, and synchronizer park/unpark times now use a new
MonotonicTimetype backed bySystem.nanoTime(), so system clock adjustments no longer stretch or shrink those waits.awaitUntil,earliest, andbuildNextAvailableSynchronizeridle waits use monotonic durations (until) instead ofDuration.between(Instant.now(), …).Adds
MonotonicTime(now,plus,isBeforewith overflow-safe comparison,until) andMonotonicTimeTestfor nanosecond overflow edge cases.Risk for reviewers: Verify all call sites that compared or stored these deadlines now consistently use
MonotonicTimeand that nothing still mixesInstantfor the same logical deadlines.Reviewed by Cursor Bugbot for commit 5198a56. Bugbot is set up for automated code reviews on this repo. Configure here.